Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: direct response #4508

Merged
merged 3 commits into from
Oct 24, 2024
Merged

feat: direct response #4508

merged 3 commits into from
Oct 24, 2024

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Oct 24, 2024

Relates to #2714

Relates to envoyproxy#2714

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner October 24, 2024 02:06
@arkodg arkodg marked this pull request as draft October 24, 2024 02:07
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 50.90909% with 81 lines in your changes missing coverage. Please review.

Project coverage is 65.65%. Comparing base (8adbf1d) to head (7d68144).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/filters.go 0.00% 25 Missing ⚠️
internal/gatewayapi/filters.go 36.36% 20 Missing and 1 partial ⚠️
internal/provider/kubernetes/indexers.go 14.28% 17 Missing and 1 partial ⚠️
internal/provider/kubernetes/predicates.go 30.00% 5 Missing and 2 partials ⚠️
internal/gatewayapi/backendtrafficpolicy.go 83.33% 6 Missing ⚠️
internal/provider/kubernetes/controller.go 0.00% 2 Missing and 1 partial ⚠️
internal/provider/kubernetes/routes.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4508      +/-   ##
==========================================
- Coverage   65.74%   65.65%   -0.10%     
==========================================
  Files         210      210              
  Lines       31516    31612      +96     
==========================================
+ Hits        20721    20754      +33     
- Misses       9598     9659      +61     
- Partials     1197     1199       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg marked this pull request as ready for review October 24, 2024 03:19
@arkodg arkodg requested a review from a team October 24, 2024 03:19
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@zirain zirain merged commit 9353be2 into envoyproxy:main Oct 24, 2024
23 of 24 checks passed
rudrakhp pushed a commit to rudrakhp/gateway that referenced this pull request Oct 24, 2024
* feat: direct response

Relates to envoyproxy#2714

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* provider logic

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* default status code is 200

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
rudrakhp pushed a commit to rudrakhp/gateway that referenced this pull request Oct 24, 2024
* feat: direct response

Relates to envoyproxy#2714

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* provider logic

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* default status code is 200

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
rudrakhp pushed a commit to rudrakhp/gateway that referenced this pull request Oct 24, 2024
* feat: direct response

Relates to envoyproxy#2714

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* provider logic

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* default status code is 200

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
@arkodg arkodg deleted the direct-response-impl branch October 24, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants