Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response options configuration merge vs proto durations #392

Open
oschaaf opened this issue Jul 1, 2020 · 0 comments
Open

Response options configuration merge vs proto durations #392

oschaaf opened this issue Jul 1, 2020 · 0 comments

Comments

@oschaaf
Copy link
Member

oschaaf commented Jul 1, 2020

In #390 one of the expectations failed unexpectedly while testing request-level configuration.
It fails, because the duration that gets merged is a two-field message: it would make here to see
both the number of seconds and nanoseconds to be overridden.
However, the seconds part is set to '0', which equates to the default of the underlying int
type, and the fact that we are using proto3, which doesn't merge default values.

For merging purposes, we it would be more intuitive for to treat durations as an atomic field:
if either seconds or nanoseconds is provided, both fields should be affected in the merge result.
An override specified in json looks like "0.01s" after all, and it doesn't make sense for the merge to treat
the whole number and the fraction as separate components to consider for merge.

@oschaaf oschaaf mentioned this issue Jul 1, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant