Update for bazel incompatible changes #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this build fails without my changes too, I'll investigate #199 |
|
Ok I will rebase this after #200 is merged which seemed to fix the issue |
When building envoy with bazel@HEAD to test for regressions, bazel CI tests with upcoming incompatible changes. This PR fixes a few of those experienced upstream: `--incompatible_require_ctx_in_configure_features` & `--incompatible_enable_cc_toolchain_resolution`: Updated rules_go to include upstream fixes for these. `--incompatible_depset_is_not_iterable`: Call `to_list` where needed `--incompatible_disable_deprecated_attr_params`: Change `single_file` to `allow_single_file` `--incompatible_no_support_tools_in_action_inputs`: Move `ctx.executable._plugin` to `tools` instead of `inputs` `--incompatible_disable_legacy_proto_provider`: Update proto API usage following bazelbuild/bazel#7152 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
|
Updated removing the gazelle commit (is that ok?) and we're green! Thanks @htuch! |
|
Also I'm not sure what the release process is with this repo, but if possible it would be great to create a new release once this is merged so we can fix envoyproxy/envoy#6995 upstream! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building envoy with bazel@HEAD to test for regressions, bazel CI
tests with upcoming incompatible changes. This PR fixes a few of those
experienced upstream:
--incompatible_require_ctx_in_configure_features&--incompatible_enable_cc_toolchain_resolution:Updated rules_go to include upstream fixes for these.
--incompatible_depset_is_not_iterable:Call
to_listwhere needed--incompatible_disable_deprecated_attr_params:Change
single_filetoallow_single_file--incompatible_no_support_tools_in_action_inputs:Move
ctx.executable._plugintotoolsinstead ofinputs--incompatible_disable_legacy_proto_provider:Update proto API usage following bazelbuild/bazel#7152