Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detailed_metric support for dynamic config using xDS server #461

Closed
akondapuram opened this issue Nov 28, 2023 · 2 comments
Closed

detailed_metric support for dynamic config using xDS server #461

akondapuram opened this issue Nov 28, 2023 · 2 comments

Comments

@akondapuram
Copy link
Contributor

Hi all, we have a scenario where we would like to have the detailed_metric support for the dynamic config as well.
The open source solution using static limits supports a feature called detailed_metric in the descriptor of the ratelimit config for extending the metrics for unspecified values. However, the dynamic config using xDS Server (xds-config) doesn't support this field. This is the RatelimitConfig proto it uses.

Could we please add the detailed_metric field to dynamic config as well? Thank you!

@akondapuram
Copy link
Contributor Author

Created 2 PRs

  1. For the go-control-plane repo. This has to be checked in first as the second PR has a dependency on this one.
  2. For the ratelimit repo.

@akondapuram
Copy link
Contributor Author

The change has been merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant