Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should EnzoMethodFeedbackSTARSS account for metal contributions when computing mmw? #311

Open
mabruzzo opened this issue May 24, 2023 · 0 comments
Open

Should EnzoMethodFeedbackSTARSS account for metal contributions when computing mmw? #311

mabruzzo opened this issue May 24, 2023 · 0 comments
Labels
question Further information is requested

Comments

@mabruzzo
Copy link
Contributor

Currently, EnzoMethodFeedbackSTARSS does not account for the contribution from metals when computing the mean molecular weight. This issue was raised during the review of PR #290.

It's unclear whether this was intentional or an oversight. Either we should fix this or add a clarifying comment. (The code needed to include contributions from MMW is added in a comment by PR #290).

I believe @WillHicks96 originally wrote this code.
@mabruzzo mabruzzo added the question Further information is requested label May 24, 2023
@mabruzzo mabruzzo mentioned this issue May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mabruzzo