Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

WebAuthN Support #659

Merged
merged 2 commits into from
Sep 16, 2019
Merged

WebAuthN Support #659

merged 2 commits into from
Sep 16, 2019

Conversation

b1bart
Copy link
Contributor

@b1bart b1bart commented Sep 6, 2019

Change Description

Added support for WebAuthN keys and signatures to the c++ wrapper types. Deprecated the fixed size capi_ types for both signature and public_key as they are no longer sufficient to represent the potentially variable-sized keys in the future

API Changes

  • API Changes
    The c++ types for eosio::signature and eosio::public_key are different. Before these were simple structs with public fields for the "which" type of public key and underlying buffer of bytes, these are now variants of either an std::array<char, 65> or a webauthn_signature and std::array<char, 33> or a webauthn_public_key respectively.

Documentation Additions

  • Documentation Additions

The c++ types for eosio::signature and eosio::public_key have become significantly more complex to handle the unexposed details of what those data types really were. This resulted in shifting the types to std::variant and creating (sometimes shared) sub-types to represent the underlying types. Need to review the docs to make sure its reasonably legible.

…es. Deprecated the fixed size `capi_` types for both signature and public_key as they are no longer sufficient to represent the potentially variable-sized keys in the future
@b1bart b1bart marked this pull request as ready for review September 10, 2019 20:39
@arhag arhag merged commit c54aca0 into develop Sep 16, 2019
@arhag arhag deleted the feature/webauthn-support branch September 16, 2019 23:58
rise-worlds pushed a commit to potato-coin/eosio.cdt that referenced this pull request Jul 14, 2020
@boid-com
Copy link

Is this change to eosio::public_key properly documented?

All official documentation points to cdt 1.5
https://developers.eos.io/manuals/eosio.cdt/v1.5/structeosio_1_1public__key

cdt 1.7 does not contain eosio::public_key documentation

@iamveritas
Copy link
Contributor

iamveritas commented Nov 5, 2020

public_key is now an alias not a struct anymore and, although it is annotated properly, in doxygen style, the documentation generation platform is not parsing it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants