This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Added support for WebAuthN keys and signatures to the c++ wrapper types. Deprecated the fixed size
capi_
types for both signature and public_key as they are no longer sufficient to represent the potentially variable-sized keys in the futureAPI Changes
The c++ types for
eosio::signature
andeosio::public_key
are different. Before these were simple structs with public fields for the "which" type of public key and underlying buffer of bytes, these are now variants of either anstd::array<char, 65>
or awebauthn_signature
andstd::array<char, 33>
or awebauthn_public_key
respectively.Documentation Additions
The c++ types for
eosio::signature
andeosio::public_key
have become significantly more complex to handle the unexposed details of what those data types really were. This resulted in shifting the types tostd::variant
and creating (sometimes shared) sub-types to represent the underlying types. Need to review the docs to make sure its reasonably legible.