Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node module should not use shared flag #204

Closed
yarkinwho opened this issue Mar 26, 2024 · 0 comments · Fixed by #207
Closed

Node module should not use shared flag #204

yarkinwho opened this issue Mar 26, 2024 · 0 comments · Fixed by #207
Assignees
@yarkinwho
Labels
👍 lgtm
Milestone
EVM Node 1.0.0-rc1

Comments

@yarkinwho
Copy link
Contributor

This is because node suppose to be the only read-write user of the db, it would be better to fail if the node founds the db config are incompatible instead of silently use the setting in db with the shared flag.

Part of the issues discussed in #189
@github-project-automation github-project-automation bot moved this to Todo in EOS EVM Mar 26, 2024
@yarkinwho yarkinwho self-assigned this Mar 26, 2024
This was referenced Mar 28, 2024
Merged
Closed
@iamphoumin852 iamphoumin852 moved this from Todo to In Progress in EOS EVM Apr 2, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in EOS EVM Apr 7, 2024
@stephenpdeos stephenpdeos added this to the EVM Node 1.0.0-rc1 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yarkinwho yarkinwho

Labels
👍 lgtm
Projects
EOS EVM
Status: Done
Milestone
EVM Node 1.0.0-rc1
Development

Successfully merging a pull request may close this issue.

Fix mdbx related issues eosnetworkfoundation/eos-evm-node
2 participants
@yarkinwho @stephenpdeos