Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping discord.js version (v13 -> v14) #15

Open
pythonmcpi opened this issue Oct 31, 2023 · 2 comments
Open

Bumping discord.js version (v13 -> v14) #15

pythonmcpi opened this issue Oct 31, 2023 · 2 comments
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers

Comments

@pythonmcpi
Copy link

Current stable release of discord.js: 14.13.0
Current discord.js version gauntlet targets: ^13.0.0

We should update to v14 to keep up with discord.js development. However, I'm not sure if it would be better to update sooner, or once we finish cleaning up the project. discordjs.guide has a list of the breaking changes between d.js v13 and 14, but a lot of it isn't Discord API related so it shouldn't affect gauntlet too much.

@ephemeralrogue
Copy link
Owner

@pythonmcpi I 1000% support updating to the discord.js v14.

One thing we've been discussing in the Discord server is mocking the Discord API rather than creating mocks through the discord.js library. In either case, we can still make use of the discord.js library vis-a-vis parsing the API calls a la dismock. There are pros and cons to this approach, though the biggest benefit would be that anyone writing a bot in JS/TypeScript would be able to use this library if we went the route of mocking the Discord API: start of the discord thread

@ephemeralrogue ephemeralrogue added good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Oct 31, 2023
@ephemeralrogue
Copy link
Owner

Some notes on this upgrade. I think this issue is worth prioritizing.

A thorough upgrade here will require resolving breaking changes, and the removal of src/types/patches.ts with all updates being properly implemented across the codebase. A separate issue will address the refactoring of the types file as a whole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers
Projects
Development

No branches or pull requests

2 participants