Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests on Windows #420

Closed
Tracked by #423
sbfnk opened this issue Jul 17, 2023 · 10 comments
Closed
Tracked by #423

Failing tests on Windows #420

sbfnk opened this issue Jul 17, 2023 · 10 comments

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Jul 17, 2023

A test is currently failing on Windows. It is not clear what has caused this, and it does not seem to be linked to the latest PR #416 (as it also happens without its main change): https://github.com/epiforecasts/EpiNow2/actions/runs/5554848587/jobs/10147747916?pr=419

@sbfnk sbfnk added the bug Something isn't working label Jul 17, 2023
@seabbs
Copy link
Contributor

seabbs commented Jul 17, 2023

Note that we saw some instability in performance when updating the delay handling code that could be related to this.

@sbfnk
Copy link
Contributor Author

sbfnk commented Jul 17, 2023

This now also happens on older version of the code suggesting that it has to do with windows-specific updates to the GHA rather than any specific code updates.

@seabbs
Copy link
Contributor

seabbs commented Jul 17, 2023

well that is good news and also I suppose bad news

@seabbs
Copy link
Contributor

seabbs commented Jul 17, 2023

I guess for now changing the estimate_secondary test to be a little flimsy would be a good idea

@sbfnk
Copy link
Contributor Author

sbfnk commented Jul 17, 2023

I'm not completely convinced the problem is in estimate_secondary as the fitting failures occur on all platforms. Something strange is happening sometimes on windows which may be unrelated
https://github.com/epiforecasts/EpiNow2/actions/runs/5577074428/jobs/10190215287?pr=418#step:6:554

@sbfnk sbfnk mentioned this issue Jul 18, 2023
18 tasks
@sbfnk
Copy link
Contributor Author

sbfnk commented Jul 18, 2023

The windows failures seem to occur at random times during the testing. Here's another one
https://github.com/epiforecasts/EpiNow2/actions/runs/5584609269/jobs/10207381065#step:6:501

@sbfnk
Copy link
Contributor Author

sbfnk commented Jul 18, 2023

I wonder if this could be linked to the recent update to StanHeaders (on CRAN as of 2023-06-14) https://cran.r-project.org/web/packages/StanHeaders/index.html
Noting that Ubuntu actions all seem to be failing more often than they used to with random seg faults.

@seabbs
Copy link
Contributor

seabbs commented Jul 18, 2023

That seems very possible though far from ideal

@sbfnk
Copy link
Contributor Author

sbfnk commented Jul 20, 2023

In summary, this seems to happen intermittently and at various stages of testing (#418) on current as well as previous versions of EpiNow2 (#421) and with current and older versions of StanHeaders (#427). It's not clear what distinguishes these runs from the ones running successfully on macOS.

@sbfnk sbfnk removed the bug Something isn't working label Jul 22, 2023
@sbfnk
Copy link
Contributor Author

sbfnk commented Jul 22, 2023

This seems to have resolved itself without any code change.

@sbfnk sbfnk closed this as completed Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants