Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update total downloads badge #821

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Update total downloads badge #821

merged 1 commit into from
Oct 3, 2024

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Oct 3, 2024

Motivated in the same way as #820. Copies in the https badge. Doesn't match the colour but can do so.

@seabbs
Copy link
Contributor Author

seabbs commented Oct 3, 2024

I think the alternative is to change what we have currently from HTTP to https directly?

@seabbs
Copy link
Contributor Author

seabbs commented Oct 3, 2024

I'm not really sure this change is needed? The current badge loads for me on the pkgdown site but not on Github. I have a bunch of custom stuff overlaying my github though so maybe its just me

@sbfnk
Copy link
Contributor

sbfnk commented Oct 3, 2024

it doesn't load for me so this change is probably a good thing.

@sbfnk sbfnk enabled auto-merge October 3, 2024 10:44
@sbfnk sbfnk added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit d7222c8 Oct 3, 2024
9 checks passed
@sbfnk sbfnk deleted the update-downloads-badge branch October 3, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants