Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document design decisions #7

Open
jamesmbaazam opened this issue Oct 7, 2024 · 7 comments
Open

Document design decisions #7

jamesmbaazam opened this issue Oct 7, 2024 · 7 comments

Comments

@jamesmbaazam
Copy link

Let's take a step back and have a call to brainstorm and document the design decisions we want to stick to here. This will also capture wider interoperability issues (related: #6 and epiforecasts/EpiNow2#823 (comment))

@jamesmbaazam jamesmbaazam changed the title Design vignette Document design decisions Oct 7, 2024
@sbfnk
Copy link
Contributor

sbfnk commented Oct 8, 2024

Just noting that we've already got https://github.com/epiforecasts/dist.spec/blob/main/inst/design.md

@jamesmbaazam
Copy link
Author

Yes, I had that in mind as a starting point. I think we should make it a vignette to properly expose it, though.

I'm also not exactly sure how the other packages would adopt it into their current infrastructure or how much breaking changes they'd need to make to adopt this package. It would be good to access that by engaging with the developers of the listed packages.

@seabbs
Copy link

seabbs commented Oct 8, 2024

Noting for future reference I don't think we need to target epidist as that uses the brms tooling natively (though happy to hear why we might want to do that)/

@seabbs
Copy link

seabbs commented Oct 8, 2024

Any EpiNow2 specific functionality (especially relating to conversion to stan code) should not interfere with core functionality of the distribution interface.

I think primarycensored shows a model for how to do this and also others the hope that this functionality doesn't need to be designed as EpiNow2 only.

@jamesmbaazam
Copy link
Author

I'm yet to review primarycensored but will make a top to-do. I've heard a lot of good things about it 😉

@seabbs
Copy link

seabbs commented Oct 9, 2024

I mean only 1 person is interested and they say its great (its me)

@seabbs
Copy link

seabbs commented Oct 9, 2024

The TLDR is we ship stan code inside the R code and provides some tools to get at it and put it in peoples models either at run time or by developers. Its not ideal but its better than copy and pasting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants