Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

V0.4.0 #19

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

V0.4.0 #19

wants to merge 12 commits into from

Conversation

aryoepigene
Copy link
Contributor

@aryoepigene aryoepigene commented Jul 26, 2021

What?

pyComBat sklearn stylizing:

  • PyCombat as a transformer class with .fit() and .transform()
  • Add and update Documentation with type hinting
  • Several variable renaming (for abbreviated variable i.e. dat)
  • Inline documentation style update
  • Includes Black formatting
  • Separate unit tests

Why?

This PR is linked to a raised issue. .fit_transform() seems to be a more pythonic way of shipping this type of solution. Despite there is a very thin line (if there is any) between the training and inference process. This PR attempts to split the first half of the combat process that sets up the necessary computation tools as .fit() and adjust_data() part as .transform()

Testing

All passed the unit tests

Screenshots

Unit Tests
Screenshot 2021-07-26 at 21 23 10

Code Coverage
Screenshot 2021-07-26 at 21 23 48

Anything else?

@aryoepigene aryoepigene added the enhancement New feature or request label Jul 26, 2021
@aryoepigene aryoepigene self-assigned this Jul 26, 2021
@aryoepigene aryoepigene linked an issue Jul 26, 2021 that may be closed by this pull request
@aryoepigene aryoepigene changed the title V0.3.1 V0.3.2 Mar 16, 2022
@aryoepigene aryoepigene changed the title V0.3.2 V0.4.0 Apr 11, 2022
@aryoepigene aryoepigene marked this pull request as draft April 11, 2022 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fit transform and transform
1 participant