diff --git a/README.md b/README.md index 973466fe..3ad844e8 100644 --- a/README.md +++ b/README.md @@ -28,12 +28,12 @@ cloning. See tests/README.md for more info about the test setup. ### browser (Chrome) -135/144 of which 5 are due to missing whitespace. +136/144 of which 5 are due to missing whitespace. ### jsdom
-report 125/159 passing of which 16 are due `::before { content }`, 14 are accessible desc, 8 are pathological +report 126/159 passing of which 16 are due `::before { content }`, 14 are accessible desc, 7 are pathological ```bash web-platform-tests @@ -79,7 +79,7 @@ cloning. See tests/README.md for more info about the test setup. ✓ name_from_content_of_label-manual.html ✓ name_from_content_of_labelledby_element-manual.html ✓ name_from_content_of_labelledby_elements_one_of_which_is_hidden-manual.html - ✓ [expected fail] name_heading-combobox-focusable-alternative-manual.html + ✓ name_heading-combobox-focusable-alternative-manual.html ✓ name_image-title-manual.html ✓ name_link-mixed-content-manual.html ✓ name_link-with-label-manual.html diff --git a/sources/accessible-name.ts b/sources/accessible-name.ts index d000ba95..bc1fca09 100644 --- a/sources/accessible-name.ts +++ b/sources/accessible-name.ts @@ -455,12 +455,13 @@ export function computeAccessibleName( } // 2E - if (skipToStep2E || context.isEmbeddedInLabel) { + if (skipToStep2E || context.isEmbeddedInLabel || context.isReferenced) { if (hasAnyConcreteRoles(current, ["combobox", "listbox"])) { consultedNodes.add(current); const selectedOptions = querySelectedOptions(current); if (selectedOptions.length === 0) { - return ""; + // defined per test `name_heading_combobox` + return isHTMLInputElement(current) ? current.value : ""; } return Array.from(selectedOptions) .map(selectedOption => { diff --git a/tests/cypress/integration/web-platform-test.js b/tests/cypress/integration/web-platform-test.js index 42a68bf4..f6b889ff 100644 --- a/tests/cypress/integration/web-platform-test.js +++ b/tests/cypress/integration/web-platform-test.js @@ -34,7 +34,7 @@ context("wpt", () => { "name_from_content_of_labelledby_elements_one_of_which_is_hidden-manual", "pass" ], - ["name_heading-combobox-focusable-alternative-manual", "fail"], // wrong text alternative, see mailing list + ["name_heading-combobox-focusable-alternative-manual", "pass"], ["name_image-title-manual", "pass"], ["name_link-mixed-content-manual", "pass"], ["name_link-with-label-manual", "pass"], diff --git a/tests/wpt-jsdom/to-run.yaml b/tests/wpt-jsdom/to-run.yaml index b6093761..c7aa4060 100644 --- a/tests/wpt-jsdom/to-run.yaml +++ b/tests/wpt-jsdom/to-run.yaml @@ -5,8 +5,6 @@ name_file-label-inline-block-elements-manual.html: [fail, getComputedStyle display defaults not implemented] name_file-label-inline-block-styles-manual.html: [fail, getComputedStyle pseudo selector not implemented] -name_heading-combobox-focusable-alternative-manual.html: - [fail, could not find spec for that] name_test_case_552-manual.html: [fail, getComputedStyle pseudo selector not implemented] name_test_case_553-manual.html: