From f6024fbcf6f8d4b693efedef1852203387508522 Mon Sep 17 00:00:00 2001
From: sistemd <enntheprogrammer@gmail.com>
Date: Tue, 13 Feb 2024 11:28:15 +0100
Subject: [PATCH] test

---
 .../v06/method/trace_block_transactions.rs    | 34 +++++++++++++++++--
 1 file changed, 31 insertions(+), 3 deletions(-)

diff --git a/crates/rpc/src/v06/method/trace_block_transactions.rs b/crates/rpc/src/v06/method/trace_block_transactions.rs
index 15fd9a8cfe..35f415abd8 100644
--- a/crates/rpc/src/v06/method/trace_block_transactions.rs
+++ b/crates/rpc/src/v06/method/trace_block_transactions.rs
@@ -15,19 +15,19 @@ use pathfinder_common::transaction::Transaction;
 
 use super::simulate_transactions::dto::TransactionTrace;
 
-#[derive(Deserialize, Debug)]
+#[derive(Deserialize, Debug, Clone)]
 #[serde(deny_unknown_fields)]
 pub struct TraceBlockTransactionsInput {
     block_id: BlockId,
 }
 
-#[derive(Debug, Serialize, Eq, PartialEq)]
+#[derive(Debug, Serialize, Eq, PartialEq, Clone)]
 pub struct Trace {
     pub transaction_hash: TransactionHash,
     pub trace_root: TransactionTrace,
 }
 
-#[derive(Debug, Serialize, Eq, PartialEq)]
+#[derive(Debug, Serialize, Eq, PartialEq, Clone)]
 pub struct TraceBlockTransactionsOutput(pub Vec<Trace>);
 
 #[derive(Debug)]
@@ -275,6 +275,7 @@ pub(crate) mod tests {
     use pathfinder_common::{
         block_hash, felt, receipt::Receipt, BlockHeader, GasPrice, SierraHash, TransactionIndex,
     };
+    use tokio::task::JoinSet;
 
     use super::*;
 
@@ -391,6 +392,33 @@ pub(crate) mod tests {
         Ok(())
     }
 
+    /// Test that multiple requests for the same block return correctly. This checks that the
+    /// trace request coalescing doesn't do anything unexpected.
+    #[tokio::test]
+    async fn test_request_coalescing() -> anyhow::Result<()> {
+        const NUM_REQUESTS: usize = 1000;
+
+        let (context, next_block_header, traces) = setup_multi_tx_trace_test().await?;
+
+        let input = TraceBlockTransactionsInput {
+            block_id: next_block_header.hash.into(),
+        };
+        let mut joins = JoinSet::new();
+        for _ in 0..NUM_REQUESTS {
+            let input = input.clone();
+            let context = context.clone();
+            joins.spawn(async move { trace_block_transactions(context, input).await.unwrap() });
+        }
+        let mut outputs = Vec::new();
+        while let Some(output) = joins.join_next().await {
+            outputs.push(output.unwrap());
+        }
+        let expected = vec![TraceBlockTransactionsOutput(traces); NUM_REQUESTS];
+
+        pretty_assertions_sorted::assert_eq!(outputs, expected);
+        Ok(())
+    }
+
     pub(crate) async fn setup_multi_tx_trace_pending_test(
     ) -> anyhow::Result<(RpcContext, Vec<Trace>)> {
         use super::super::simulate_transactions::tests::fixtures;