[Bug]: Some resources may be incorrectly ignoring HTTP 403 responses

[ctreatma]

Description

The Metal API can return an HTTP 403 for a read request on a Metal device that fails during provisioning or deprovisioning. Due to this API behavior, the metal_device resource in some cases treats a 403 response as a deleted device:

• equinix_metal_device 403s on failed provision are not detected #233
• check for forbidden in equinix_metal_device read #235

As far as I know, Metal devices are the only resources that exhibit this behavior, and that other resources should treat 403 responses as errors rather than deletions. However, numerous other resources are also configured to ignore 403 errors during the resource lifecycle and/or when sweeping test resources:

• terraform-provider-equinix/internal/resources/metal/vlan/resource.go

  Line 170 in b1ed71b

  if equinix_errors.IgnoreResponseErrors(equinix_errors.HttpForbidden, equinix_errors.HttpNotFound)(resp, err) != nil {

• terraform-provider-equinix/internal/resources/fabric/connection/sweeper.go

  Line 67 in b1ed71b

  if equinix_errors.IgnoreHttpResponseErrors(equinix_errors.HttpForbidden, equinix_errors.HttpNotFound)(resp, err) != nil {

• terraform-provider-equinix/equinix/resource_metal_ip_attachment.go

  Line 98 in b1ed71b

  if equinix_errors.IgnoreResponseErrors(equinix_errors.HttpForbidden, equinix_errors.HttpNotFound)(resp, err) != nil {

Searching this repo for "Forbidden" gives a better view of how broadly we ignore 403s.

Is this intentional behavior? Is it valid? I don't see any documentation that mentions these special error cases.

New or Affected Terraform Resources

equinix_metal_vlan
equinix_metal_virtual_circuit
...and more

Potential Terraform Configuration

No response