Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hover state for the menu component to make it more readable for Universal Design #1048

Closed
2 tasks
lucasveil opened this issue Jan 19, 2021 · 3 comments
Closed
2 tasks
Assignees
Labels

Comments

@lucasveil
Copy link
Contributor

lucasveil commented Jan 19, 2021

As follow up to this slack discussion it appears that the hover state of the menu component is not seen on a low contrast screen. For a better readability suggested action are:

  • change the weight of the text
  • update the navigation token
@lucasveil
Copy link
Contributor Author

Material Design, Carbon and Altassian uses the same pattern for menus.
And here is the WCAG documentation

@BirteThornquist BirteThornquist self-assigned this Apr 16, 2021
@BirteThornquist
Copy link
Contributor

Ready for review @lucasveil. I added a new text style for Navigation/Menu Title hover in the design tokens here And used this new text style for the hover state of the Menu Item here

@lucasveil
Copy link
Contributor Author

Nice work. Approved for me @BirteThornquist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants