-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Progress indicators #1090
Conversation
🔥 Removed variant prop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s one small step for man, one giant leap for EDS. 👍
Depending on what we do with the Storefront, we might have to update the examples there as well after release
libraries/core-react/src/components/Progress/Circular/CircularProgress.tokens.ts
Show resolved
Hide resolved
@@ -1,7 +1,7 @@ | |||
import * as React from 'react' | |||
import { forwardRef, Ref, SVGProps } from 'react' | |||
import { forwardRef, SVGProps, Ref } from 'react' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
resolves #1061
resolves #1089
Updates
color
option for all progress indicators.Dots
andCircular
have acolor
prop.className
usage as it served no purpose, looked like old testing/approach.div
wrapper onCircular
)LinearProgress
to use ternary operator to avoid duplicate divs forindeterminate
variantProgress
to be more inline with library. You can now choose between usingLinearProgress
orProgress.Linear
Breaking changes⚠️
variant
fromDotsProgress
as this did not conform with our component apis. Color of dots is now determined bycolor
prop and one of the agreed upon color names,primary
,neutral
ortetriary
.Button
becauseCircularProgress
needs to besize=16
insideButton