Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Progress indicators #1090

Merged
merged 27 commits into from
Feb 2, 2021

Conversation

mimarz
Copy link
Contributor

@mimarz mimarz commented Jan 28, 2021

resolves #1061
resolves #1089

Updates

  • Conformed on color option for all progress indicators.
  • Dots and Circular have a color prop.
  • Cleaned up and updated code to "latest" iteration of component architecture and typescript knowledge
  • Removed explicit className usage as it served no purpose, looked like old testing/approach.
  • All progress indicators are now pure svg icons with css animations. ( Removed unneeded div wrapper on Circular)
  • Changed LinearProgress to use ternary operator to avoid duplicate divs for indeterminate variant
  • Added compound component Progress to be more inline with library. You can now choose between using LinearProgress or Progress.Linear
  • Updated stories to be more consistent

Breaking changes ⚠️

  • Removed variant from DotsProgress as this did not conform with our component apis. Color of dots is now determined by color prop and one of the agreed upon color names, primary, neutral or tetriary.
  • Removed forced svg size inside Button because CircularProgress needs to be size=16 inside Button

@mimarz mimarz changed the title [WIP] Progress indicator size Update Progress indicators Feb 2, 2021
@mimarz mimarz marked this pull request as ready for review February 2, 2021 09:27
Copy link
Contributor

@wenche wenche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s one small step for man, one giant leap for EDS. 👍

Depending on what we do with the Storefront, we might have to update the examples there as well after release

@@ -1,7 +1,7 @@
import * as React from 'react'
import { forwardRef, Ref, SVGProps } from 'react'
import { forwardRef, SVGProps, Ref } from 'react'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤪

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Copy link
Contributor

@pomfrida pomfrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mimarz mimarz merged commit ac2cbe5 into equinor:develop Feb 2, 2021
@mimarz mimarz deleted the react/progress-indicator-size branch February 2, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement missing progress indicator colors Re-sizeable progress indicator
3 participants