✨ Added size to Dots progress indicator #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenche
approved these changes
Feb 2, 2021
| const { container } = render(<StyledProgress size={64} />) | ||
| const progress = container.firstChild | ||
| expect(progress).toHaveAttribute('width', '64') | ||
| }) |
There was a problem hiding this comment.
Assuming that we shouldn't have knowledge of implementation details, would it be better to test for height as well? 🤔
There was a problem hiding this comment.
Its 1/4 of height, which we could test.. but then again, its kinda implementation detail and kinda not. Its been decided by design 🤔 @wenche
There was a problem hiding this comment.
Yeah... Maybe it could be more of a "has height set" approach to make sure it's a circle
There was a problem hiding this comment.
Updated tests @wenche
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #417
After talking with @equinor/eds-ux we decided to a
sizeoption forDotsprogress so that it may better suit loading states for pages or bigger widgets.