Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACCORDIAN: As a designer I need to review the suggestions from Figma/documentation QA #115

Closed
4 tasks done
BeckyBrekke opened this issue Oct 10, 2019 · 1 comment
Closed
4 tasks done

ACCORDIAN: As a designer I need to review the suggestions from Figma/documentation QA #115

BeckyBrekke opened this issue Oct 10, 2019 · 1 comment
Assignees
@jonjaatun @benkeq
Labels
design figma storefront

Comments

@BeckyBrekke
Copy link
Contributor

BeckyBrekke commented Oct 10, 2019 •
edited by jonjaatun
Loading

  • Review suggestions/comments
  • Decide if adjustments should be made
  • Update documentation/Figma accordingly
  • Perform documentation QA
    Comments from Ørjan Blytt Polden
    The text given under Header Area can be clarified further, I think. Specifically by having one sentence first talking about interacting with the header area itself, and then another sentence after talking about having additional actions within the header area that must be interacted with directly.
@jonjaatun jonjaatun self-assigned this Jan 24, 2020
@jonjaatun
Copy link
Contributor

Seems to me like this have already been addressed? Nothing to fix.

Figma links to action left and dual variations is missing though, so I added those to the documentation.

@benkeq benkeq closed this as completed Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonjaatun jonjaatun

@benkeq benkeq

Labels
design figma storefront
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonjaatun @BeckyBrekke @benkeq