Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip: Displays when title is "" #1292

Closed
HansKristianVikOlsen opened this issue Apr 21, 2021 · 5 comments · Fixed by #1311
Closed

Tooltip: Displays when title is "" #1292

HansKristianVikOlsen opened this issue Apr 21, 2021 · 5 comments · Fixed by #1311
Assignees
Labels
🐛 bug Something isn't working

Comments

@HansKristianVikOlsen
Copy link

HansKristianVikOlsen commented Apr 21, 2021

Should not be displayed when title is ""/blank. This is an old issue that reappeared with 0.10.1.

Also, why was the "open" property removed from tooltip? It was very handy

@HansKristianVikOlsen HansKristianVikOlsen added the 🐛 bug Something isn't working label Apr 21, 2021
@mimarz
Copy link
Contributor

mimarz commented Apr 28, 2021

doh

Sorry for the re-introduced bug 🐛
We'll get it fixed for it next release 😊

We removed the open after improving the the open/close detection internally, as well as according to best practices its only supposed to show when a user interacts with the element. In addition to the newly introduced openDelay we thought we covered all use-cases. What use-case do you need to control the open state of the tooltip externally?

@HansKristianVikOlsen
Copy link
Author

No worries, happy to report! I used the Open property to display tooltips of why something was disabled. For instance, if a WBS field was not provided in the project/study(as we call it), it will pop up automatically and users would immediately see what is missing instead of hovering it first. So it is not necessary, it just to make it more obvious why something was disabled :)

@mimarz
Copy link
Contributor

mimarz commented Apr 28, 2021

No worries, happy to report! I used the Open property to display tooltips of why something was disabled. For instance, if a WBS field was not provided in the project/study(as we call it), it will pop up automatically and users would immediately see what is missing instead of hovering it first. So it is not necessary, it just to make it more obvious why something was disabled :)

Ah, yeah. The designers for EDS have designed this use-case as the background/border/icon would change to "error" color to indicate something was wrong, then tooltip shows on hover as to avoid to much clutter if you have x amount of fields

@mimarz
Copy link
Contributor

mimarz commented Apr 29, 2021

@HansKristianVikOlsen We'll fix the opening of tooltip when string is empty. As for re-introducing the open functionality I have created a separate feature request (#1312) for this as it needs some coordination with our ux designers on what is preferred here :)

@lucasveil
Copy link
Contributor

lucasveil commented Apr 29, 2021

@HansKristianVikOlsen The utility of a tooltip is to displays information such as a text label or a short description on hover. From our understanding you want to use the tooltip if an information is missing. In most cases we suggest users to use an icon to indicate where the information is missing. If you provide us a screenshot from your page we can assist you with the proper solution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants