Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lagging Tooltip when scrolling #1325

Closed
mimarz opened this issue May 4, 2021 · 2 comments · Fixed by #1328
Closed

Lagging Tooltip when scrolling #1325

mimarz opened this issue May 4, 2021 · 2 comments · Fixed by #1328
Labels
🐛 bug Something isn't working

Comments

@mimarz
Copy link
Contributor

mimarz commented May 4, 2021

Reported on behalf of users in Slack.

When using Tooltips inside large tables we have recorded some use-cases where the opening would lag and open after the user has hovered over the an icon.

Screenshot 2021-05-04 at 10.01.09.png
@mimarz mimarz added the 🐛 bug Something isn't working label May 4, 2021
@pomfrida
Copy link
Contributor

pomfrida commented May 4, 2021

This bug gave me deja vu 🤔

@mimarz mimarz mentioned this issue May 5, 2021
Merged
@mimarz
Copy link
Contributor Author

mimarz commented May 5, 2021 •
edited
Loading

This was fixed by better handling of setTimeout in Tooltip. Problem was related to scrolling and events such as mouseover/mouseleave not triggering during scroll (as intended by browser).

Notes: https://overreacted.io/making-setinterval-declarative-with-react-hooks/

@mimarz mimarz closed this as completed May 5, 2021
@mimarz mimarz changed the title Lagging Tooltip Lagging Tooltip when scrolling May 5, 2021
@mimarz mimarz mentioned this issue May 5, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

♻️ Better handling of timer in tooltip equinor/design-system
2 participants
@mimarz @pomfrida