Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rowsMax on TextField #1336

Closed
wigsnes opened this issue May 7, 2021 · 3 comments · Fixed by #1351
Closed

rowsMax on TextField #1336

wigsnes opened this issue May 7, 2021 · 3 comments · Fixed by #1351
Assignees

Comments

@wigsnes
Copy link

wigsnes commented May 7, 2021

Is your feature request related to a problem? Please describe.

I want to make it so that a text field expands as the content takes up to much space in the TextField, and not have a scroll-bar.

Describe the solution you'd like

Include rowsMax on TextField.

Describe alternatives you've considered

Switch to TextField from material-ui, which is boring to have to do just for rowsMax.

Demo how I want it to work

https://codesandbox.io/s/material-demo-forked-us7hp

@mimarz
Copy link
Contributor

mimarz commented May 7, 2021

Doh, that sucks! We should be able to find a solution for this. Much love for providing a codesandbox 😍

I think the plan was to have something like this when we did a touch-up on Textfield in March, but we hit a snag in terms of adornments with multilines (#1155), so its still in the backlog... 🤔

We'll have a look at these issues in our next planning meeting next Tuesday and get back to you :)

@mimarz
Copy link
Contributor

mimarz commented May 21, 2021

@wigsnes We have release this feature now and it can be found in the latest version of eds-core-react (v0.12.0)!

@wigsnes
Copy link
Author

wigsnes commented May 21, 2021

Thanks, this will work. I see some improvements that can be made if you have time, you can see codesandbox here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants