Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid aria values in Menu, Tooltip, Popover #1352

Closed
mimarz opened this issue May 12, 2021 · 0 comments · Fixed by #1360
Closed

Fix invalid aria values in Menu, Tooltip, Popover #1352

mimarz opened this issue May 12, 2021 · 0 comments · Fixed by #1360
Assignees
@mimarz

Comments

@mimarz
Copy link
Contributor

mimarz commented May 12, 2021

After we changed to conditional rendering internally the the aria-controls has invalid values.

image.png

Action

  • See if we can add the correct "aria-controls" value to the anchor element when "popup" is open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mimarz mimarz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

♿️ Clean up a11y in Menu, Tooltip & Popover equinor/design-system
1 participant
@mimarz