Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination onChange callback has strange types #1397

Closed
khollund opened this issue Jun 3, 2021 · 0 comments · Fixed by #1407
Closed

Pagination onChange callback has strange types #1397

khollund opened this issue Jun 3, 2021 · 0 comments · Fixed by #1407
Assignees
Labels
🐛 bug Something isn't working

Comments

@khollund
Copy link
Contributor

khollund commented Jun 3, 2021

Describe the bug

When using the pagination component we've been using the callback to change page. This has broken at some point, probably because we didn't implement full typescript in EDS until recently. When checking the type of the callback it says it's either a Mouse or Keyboard Event AND a FormEventHandler. (see attached image).

Steps to reproduce the bug

  1. Use the pagination component
  2. Try to use the onChange callback

Expected behavior

I assumed it would expect one type.

Specifications

  • Version: EDS 0.12.1
  • Browser: Chrome
  • OS: Windows

Additional context

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants