Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update icons sizes in react components #1403

Closed
mimarz opened this issue Jun 3, 2021 · 1 comment · Fixed by #1542
Closed

Update icons sizes in react components #1403

mimarz opened this issue Jun 3, 2021 · 1 comment · Fixed by #1542
Assignees
@mimarz
Labels
core-react eds-core-react design

Comments

@mimarz
Copy link
Contributor

mimarz commented Jun 3, 2021

All icon sizes was updated to be 24x24 (from 16x16) in Figma in issue #189, but we forgot to update the sizes in our react components...

With compact we see now that some icons are actually better fit to be 16x16 in those use-cases.

Actions

  • Do a review on which components should be 24x24 and 16x16.
@mimarz mimarz added design core-react eds-core-react labels Jun 3, 2021
@mimarz mimarz mentioned this issue Sep 2, 2021
Closed
@mimarz
Copy link
Contributor Author

mimarz commented Sep 2, 2021

Adjustments:

Textfield:

  • Comfortable Input icon: 24px
  • Helper icon: 16px
  • Compact input icon: 16px

Search:

  • Icons 24px

Accordion:

  • Cheveron icon: 24px

@mimarz mimarz self-assigned this Sep 2, 2021
@mimarz mimarz mentioned this issue Sep 6, 2021
Merged
This was referenced Sep 28, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mimarz mimarz

Labels
core-react eds-core-react design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

♻️ Update Search & Accordion icon sizes equinor/design-system
1 participant
@mimarz