Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jest is bundled with eds-core-react #1406

Closed
vnys opened this issue Jun 4, 2021 · 2 comments · Fixed by #1495
Closed

Jest is bundled with eds-core-react #1406

vnys opened this issue Jun 4, 2021 · 2 comments · Fixed by #1495
Assignees
@mimarz
Labels
🐛 bug Something isn't working

Comments

@vnys
Copy link
Member

vnys commented Jun 4, 2021

Jest is bundled with eds-core-react. It uses process.env, with the result that the components don’t work with Webpack 5.
@vnys vnys added the 🐛 bug Something isn't working label Jun 4, 2021
@vnys vnys self-assigned this Jun 4, 2021
@nilsml nilsml assigned mimarz and unassigned vnys Jul 15, 2021
@mimarz
Copy link
Contributor

mimarz commented Jul 15, 2021 •
edited
Loading

This might be fixed in react-testing-library, testing-library/react-testing-library@8a1c8e9, so updating dependencies can resolve this issue.

@mimarz mimarz mentioned this issue Jul 16, 2021
Merged
@mimarz mimarz mentioned this issue Jul 16, 2021
Closed
@mimarz
Copy link
Contributor

mimarz commented Jul 16, 2021

The cause for this was that we had a custom test renderer we used for testing menu, popover etc that was under utils. This meant that the whole react-testing-library was bundled along since it was imported by this custom test renderer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mimarz mimarz

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⬆️ Update core-react dependencies equinor/design-system
2 participants
@mimarz @vnys