Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snackbar: Replace leftAlignFrom prop with a placement prop #1488

Closed
pomfrida opened this issue Jul 15, 2021 · 1 comment · Fixed by #1528
Closed

Snackbar: Replace leftAlignFrom prop with a placement prop #1488

pomfrida opened this issue Jul 15, 2021 · 1 comment · Fixed by #1528
Assignees
@pomfrida
Labels
core-react eds-core-react

Comments

@pomfrida
Copy link
Contributor

leftAlignFrom should be replaced by a placement prop as this makes more sense
@pomfrida pomfrida added the core-react eds-core-react label Jul 15, 2021
@pomfrida pomfrida assigned pomfrida and unassigned pomfrida Jul 15, 2021
@mimarz
Copy link
Contributor

mimarz commented Aug 6, 2021

Got a question from a project about this weird behaviour where snackbar would float left when window was wide. He asked if we could have a placement prop instead, which is exactly what we are planning here so +1 :)

@pomfrida pomfrida self-assigned this Aug 20, 2021
@pomfrida pomfrida mentioned this issue Aug 24, 2021
Merged
This was referenced Sep 28, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomfrida pomfrida

Labels
core-react eds-core-react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Snackbar placement pomfrida/design-system
2 participants
@mimarz @pomfrida