Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrim disables scrolling bar #1892

Closed
HansKristianVikOlsen opened this issue Jan 14, 2022 · 1 comment · Fixed by #1894
Closed

Scrim disables scrolling bar #1892

HansKristianVikOlsen opened this issue Jan 14, 2022 · 1 comment · Fixed by #1894
Assignees
Labels
🐛 bug Something isn't working

Comments

@HansKristianVikOlsen
Copy link

  1. go here https://eds-storybook-react.azurewebsites.net/?path=/docs/feedback-scrim--default
  2. make sure you have a scrollbar by minimizing screen
  3. Click "Trigger scrim" button
  4. Click esc to cancel scrim
  5. Scroll bar is now gone!
  6. Have to refresh page to get it back

This is also happens in our app

@oddvernes
Copy link
Collaborator

Found the problem. We temporarily store the original overflow value of body before adding overflow hidden when opening scrim, but after a refactor, this value gets accidentally overwritten again with the new overflow value. I have added a fix so it does not get overwritten, will be in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants