Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "InputWrapper" component #2336

Closed
mimarz opened this issue Jun 22, 2022 · 2 comments · Fixed by #2354 or #2395
Closed

New "InputWrapper" component #2336

mimarz opened this issue Jun 22, 2022 · 2 comments · Fixed by #2354 or #2395
Assignees
Labels
core-react eds-core-react ✨ enhancement Enhancements for our existing components epic

Comments

@mimarz
Copy link
Contributor

mimarz commented Jun 22, 2022

Undecided on name, but I suggest we need a "inputWrapper" or "Field" like component which handles adornments, helpertext, label, meta and such for encompassing Input.

We currently have Search, Autocomplete, TextField, which all have different implementations of how an input is rendered along with its helpertext (or not), adornments, labels etc.

This makes it harder to maintain, ensure consistency and proper a11y.

We also have several pending issues which could easily be solved by standardising with a InputWrapper;

Goals

  • Investigate what features this component should have
    • Textfield has a similar component internally which might be extracted and used
  • Check wether this can be used for Radio, Checkbox & Switch
  • Make it easy to use our "form" components in forms

Notes

@mimarz mimarz added core-react eds-core-react ✨ enhancement Enhancements for our existing components labels Jun 22, 2022
@mimarz mimarz self-assigned this Jun 27, 2022
@mimarz mimarz added the epic label Aug 3, 2022
@mimarz
Copy link
Contributor Author

mimarz commented Aug 3, 2022

Converted this to epic as we have a few sub-tasks and testing that needs to be done with this change, aswell as created seperate branch for all work on this feat/2336-inputwrapper.

@nilsml
Copy link
Contributor

nilsml commented Sep 1, 2022

I think we should move the PR's connected to this Epic to an issue instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-react eds-core-react ✨ enhancement Enhancements for our existing components epic
Projects
None yet
2 participants