Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Autocomplete: problem with react-hook-form & mobile #2889

Closed
oddvernes opened this issue May 30, 2023 · 3 comments · Fixed by #3005
Closed

🐛 Autocomplete: problem with react-hook-form & mobile #2889

oddvernes opened this issue May 30, 2023 · 3 comments · Fixed by #3005
Assignees
@oddvernes
Labels
blocked This issue is blocked by another issue documentation To be removed

Comments

@oddvernes
Copy link
Collaborator

Multiselect with react-hook-form can trigger a fatal crash when quickly selecting items. We should add a note about this in storybook

Image

The issue seems to lie with react-hook-form so maybe not much we can do about it
@oddvernes oddvernes added the documentation To be removed label May 30, 2023
@oddvernes
Copy link
Collaborator Author

oddvernes commented Jun 2, 2023 •
edited
Loading

Update, the same crash happens clicking on any item without react-hook-forms in chrome responsive mode (in devtools click the toggle device toolbar (phone icon)). Should look into if this is caused by floating-ui. Test older version and then newest version (which requires some refactoring)

@oddvernes oddvernes self-assigned this Jun 2, 2023
@oddvernes
Copy link
Collaborator Author

Further testing (in storybook) shows autocomplete crashes on item click on mobile in general and firefox responsive mode as well. Maybe something to do with click/touch events handling

@oddvernes oddvernes changed the title Autocomplete: sb note about react-hook-form 🐛 Autocomplete: problem with react-hook-form & mobile Jun 15, 2023
@oddvernes
Copy link
Collaborator Author

relevant downshift issue downshift-js/downshift#1511

@oddvernes oddvernes added the blocked This issue is blocked by another issue label Jun 29, 2023
This was referenced Aug 9, 2023
Closed
Merged
@oddvernes oddvernes mentioned this issue Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oddvernes oddvernes

Labels
blocked This issue is blocked by another issue documentation To be removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛Autocomplete: Added a workaround for touch crash equinor/design-system
1 participant
@oddvernes