Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️🚸Dialog: rewrite to use native dialog #2949

Closed
oddvernes opened this issue Jul 6, 2023 · 0 comments · Fixed by #2950
Closed

♻️🚸Dialog: rewrite to use native dialog #2949

oddvernes opened this issue Jul 6, 2023 · 0 comments · Fixed by #2950
Assignees
@oddvernes

Comments

@oddvernes
Copy link
Collaborator

We have a lot of issues with dialog (z-index, focus trapping, autofocus etc) so I am rewriting and trying out using native <dialog> element instead of Scrim/Floating-ui. It looks like i will be able to reproduce the old behaviour and api without any breaking changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oddvernes oddvernes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

♻️🚸Dialog: refactor to use native dialog equinor/design-system
1 participant
@oddvernes