Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Notification Banner to Typescript #554

Closed
vnys opened this issue Sep 9, 2020 · 2 comments
Closed

Refactor Notification Banner to Typescript #554

vnys opened this issue Sep 9, 2020 · 2 comments
Assignees
@nicholasdalhaug
Labels
core-react eds-core-react good first issue hacktoberfest-accepted
Milestone
Hacktober Festivus 🎃

Comments

@vnys
Copy link
Member

vnys commented Sep 9, 2020 •
edited by mimarz
Loading

Create typings for Notification Banner

Make sure you fork the repository and branch from typescript before starting on this issue
@vnys vnys added core-react eds-core-react typescript labels Sep 9, 2020
@vnys vnys added this to the Typescript milestone Sep 9, 2020
@vnys vnys modified the milestones: Typescript, Hacktober Festivus Sep 22, 2020
@nicholasdalhaug
Copy link
Contributor

I would like to do this one

@mimarz
Copy link
Contributor

mimarz commented Oct 20, 2020

I would like to do this one

3, 2, 1, Sold! 🎉

@nicholasdalhaug nicholasdalhaug mentioned this issue Oct 20, 2020
Merged
@wenche wenche closed this as completed Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicholasdalhaug nicholasdalhaug

Labels
core-react eds-core-react good first issue hacktoberfest-accepted
Projects
None yet
Milestone
Hacktober Festivus 🎃
Development

No branches or pull requests
4 participants
@mimarz @wenche @vnys @nicholasdalhaug