Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conform popup logic #673

Closed
mimarz opened this issue Oct 14, 2020 · 2 comments · Fixed by #1113
Closed

Conform popup logic #673

mimarz opened this issue Oct 14, 2020 · 2 comments · Fixed by #1113
Assignees
@pomfrida
Labels
core-react eds-core-react

Comments

@mimarz
Copy link
Contributor

mimarz commented Oct 14, 2020 •
edited
Loading

  • Menu
  • Popover
  • Tooltip

These componenets are all using seperate implementations of logic for attaching and popping up on an anchor element.

Find a way to conform this logic using a popover hook.

Notes:

Features:
@mimarz mimarz added the core-react eds-core-react label Oct 22, 2020
@pomfrida pomfrida mentioned this issue Nov 5, 2020
Closed
@mimarz mimarz mentioned this issue Nov 19, 2020
Closed
@mimarz
Copy link
Contributor Author

mimarz commented Nov 19, 2020

blocked by #887

@mimarz mimarz added blocked This issue is blocked by another issue and removed blocked This issue is blocked by another issue labels Nov 19, 2020
@mimarz mimarz mentioned this issue Nov 30, 2020
Closed
@mimarz mimarz mentioned this issue Dec 16, 2020
Closed
@wenche
Copy link
Contributor

wenche commented Feb 4, 2021

See #719 as well

@mimarz mimarz mentioned this issue Feb 10, 2021
Closed
5 tasks
@pomfrida pomfrida mentioned this issue Feb 23, 2021
Merged
@pomfrida pomfrida linked a pull request Feb 23, 2021 that will close this issue
✨ Refactor Menu, Popover and Tooltip to use Popper (Old Spike PR) #1113
Merged
@pomfrida pomfrida self-assigned this Feb 23, 2021
@pomfrida pomfrida mentioned this issue Mar 22, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomfrida pomfrida

Labels
core-react eds-core-react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Refactor Menu, Popover and Tooltip to use Popper (Old Spike PR) pomfrida/design-system
3 participants
@mimarz @wenche @pomfrida