Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conform on the use of forwardRef and {...rest} #810

Closed
wenche opened this issue Nov 2, 2020 · 1 comment · Fixed by #1523
Closed

Conform on the use of forwardRef and {...rest} #810

wenche opened this issue Nov 2, 2020 · 1 comment · Fixed by #1523
Assignees
@pomfrida
Labels
core-react eds-core-react

Comments

@wenche
Copy link
Contributor

wenche commented Nov 2, 2020 •
edited
Loading

Some component (at least the Snackbar, Banner and Table components) are missing forwardRef and spreading of rest props. This should be aligned across all components.

Also, some component use {...props} at the last parameter, other as the first as some logic depends on another order.
@wenche wenche added the core-react eds-core-react label Nov 2, 2020
@wenche
Copy link
Contributor Author

wenche commented Jan 12, 2021

Table is solved by #1007

@pomfrida pomfrida mentioned this issue Jan 12, 2021
Merged
@pomfrida pomfrida self-assigned this Aug 12, 2021
@pomfrida pomfrida mentioned this issue Aug 17, 2021
Merged
This was referenced Sep 29, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomfrida pomfrida

Labels
core-react eds-core-react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Conform use of forwardRef and rest props pomfrida/design-system
2 participants
@wenche @pomfrida