Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Make format and extension provider properties #676

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

mferrera
Copy link
Collaborator

Works more toward #666

@mferrera mferrera force-pushed the objectprovider-deux branch from 7a3e1f2 to e34f5d7 Compare June 11, 2024 11:45
@mferrera mferrera changed the title WIP: Make format and extension provider properties MAINT: Make format and extension provider properties Jun 11, 2024
@mferrera mferrera force-pushed the objectprovider-deux branch from e34f5d7 to 6064088 Compare June 11, 2024 11:48
Comment on lines +76 to +78
def get_spec(self) -> SurfaceSpecification:
"""Derive data.spec for xtgeo.RegularSurface."""
logger.info("Get spec for RegularSurface")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These get_specs did not get changed, just reordered alphabetically among other getters.

@mferrera mferrera marked this pull request as ready for review June 11, 2024 11:51
@mferrera mferrera force-pushed the objectprovider-deux branch from 6064088 to dbeaad0 Compare June 11, 2024 11:51
@mferrera mferrera self-assigned this Jun 11, 2024
@mferrera mferrera requested review from jcrivenaes and tnatt June 12, 2024 12:07
Copy link
Collaborator

@tnatt tnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@mferrera mferrera force-pushed the objectprovider-deux branch from dbeaad0 to 8d7e62c Compare June 12, 2024 13:12
@mferrera mferrera merged commit 5acf2f6 into equinor:main Jun 12, 2024
13 checks passed
@mferrera mferrera deleted the objectprovider-deux branch June 12, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants