-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi selection of wells in DeckGl component map. hold 'ctrl' to select multi wells and fire callback after 'ctrl' is released #986
Comments
Linked to #531 |
There are some several challenges that we are facing within the selection solution in Deckgl component in python. The callback gets fired each time the user clicks on a well. We would like the callback beeing fired only on release of the ctrl button, however a visual feedback that the well has been selected must be provided to the user handled by DeckGl. example by changing the opacity of the current color. So the following issues have been detected.
Ideal solution for us will be the following:
Second solution
|
Another weakness is we are not able to reset selection programmatically. |
I see that the issue is closed but we are far from fixing the issues we have brought to the table. The only thing fixed now is the bug with wells that are already selected gets duplicated in the list. To solve our use case, we need a workflow as follows: This is the flow that we are expecting (Optimal solution), the main difference that it is based on ctrl button state and not selection state with respect to firing the callback.
If the above is not possible we need to expand the current solution to fulfil our need by doing the following (Not a solution we want, doing this logic on the client side is a better solution):
|
Regarding this requirement, there is a new version has been pushed into the master branch today which should help to fix some issue. |
Short summary after quick chat on the topic:
|
I will complete the following requirements one by one.
|
@ElfarriBadr @anders-kiaer |
Last task (lasso selection) is handled in #531 |
Waiting for the python release so we can test this layer thanks for the update :) |
@VincentNevermore and @anders-kiaer I am testing this solution and it seems like the selection do not fire the callback. The editedData property does not get triggered do you know what the issue might be? |
@ElfarriBadr this is not working yet. There is a new callback for handling the selection in this PR: #1333 which @VincentNevermore is working on. There is a new Storybook example in this PR that shows how to use the callback. |
Ok that explains it :). Thanks, I will keep tracking that branch |
Is the lasso selection working? i am not able to get it to work at all in the python code. I see we also have lost the possibility of multi selection. |
No lasso selection, but there is a "box" selection example here: https://equinor.github.io/webviz-subsurface-components/storybook-static/?path=/story/deckglmap-box-selection-layer--box-selection Can't find any example of multi selection. Did we have it before? If so I think you should post an issue. |
I am currently working with DeckGl Map components in webviz and i am trying to achieve a circular filtering of wells. I have a dropdown menu to filter the DeckGl well layer and i am using editedData parameter to track the user selection of wells inside the map. The challenge is that in editedData the user may select one well at a time, this will render the map and the dropdown to one well. This will leave no other wells to select on the map, the solution i am looking for is selection of multiple wells on the map before the callback is triggered. Is there any possibility to hold 'ctrl' key (or other options) and select all wells desired and run the callback after releasing the 'ctrl' key. This will resemble the range slider where the updatemode='mouseup' will only call the callback after the mouse button is released.
The text was updated successfully, but these errors were encountered: