-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.x-fromBase-type-param: Add type parameter to fromBase16 #819
Open
jozanek
wants to merge
14
commits into
develop
Choose a base branch
from
v5.x-fromBase-type-param
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
69f25d6
Adding fromBase16 to the frontend
thub1271 4d3e7b5
Update sigmastate/src/test/scala/sigmastate/lang/SigmaParserTest.scala
aslesarenko 83bc9c6
Update SigmaParserTest.scala
thub1271 5212765
removed example usage of Option.isEmpty
aslesarenko 67e0485
add-from-base-16: Update test scenarios.
jozanek 9bee61f
add-from-base-16: Enhance language specification.
jozanek c59139b
Merge pull request #737 from thub1271/add-from-base-16
aslesarenko 12610cf
set HAS_SECRETS on CI env;
greenhat 6392cbc
Merge pull request #813 from ScorexFoundation/ci-add-has-secrets
aslesarenko 60e2936
v5.x-fromBase-type-param: Add type parameter to fromBase16, update te…
jozanek d7ae28d
v5.x-fromBase-type-param: Add deserialization for all Constants.
jozanek bdcd701
v5.x-fromBase-type-param: Write proper test cases for Parser, Typer a…
jozanek 9ab6b62
v5.x-fromBase-type-param: Make test for fromBase16 general for all co…
jozanek 03152db
v5.x-fromBase-type-param: Add general test for fromBase16 in SigmaTyp…
jozanek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mean all types should be tested. See ConstantSerializerSpecification or DataSerializerSpecification for how it may look like. Those specifications are a bit less generic that they could be.
Ideally you need:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see updated version