From 173cc6126a0939cc1f849fe3ae34f5281487580a Mon Sep 17 00:00:00 2001 From: Eric Helgeson Date: Sun, 26 Jun 2022 20:48:44 -0500 Subject: [PATCH 1/4] Turn warnings on --- platformio.ini | 2 -- 1 file changed, 2 deletions(-) diff --git a/platformio.ini b/platformio.ini index 9fc4c4e..e6b40ca 100644 --- a/platformio.ini +++ b/platformio.ini @@ -11,7 +11,6 @@ upload_protocol = stlink ; Different gcc versions produce much different binaries in terms of speed. platform_packages = platformio/toolchain-gccarmnoneeabi@1.90301.200702 build_flags = - -w -DARDUINO_GENERIC_STM32F103C -DARDUINO_LIB_DISCOVERY_PHASE -DARDUINO=10813 @@ -79,7 +78,6 @@ build_flags = -D USB_MANUFACTURER="Unknown" -D USB_PRODUCT="\"BLUEPILL_F103C8\"" -D HAL_PCD_MODULE_ENABLED - -w -DARDUINO_GENERIC_STM32F103C -DARDUINO_LIB_DISCOVERY_PHASE -DARDUINO=10813 From ff8990e5c559510e2c5734b72eb69c0728de90e8 Mon Sep 17 00:00:00 2001 From: Eric Helgeson Date: Sun, 26 Jun 2022 20:49:07 -0500 Subject: [PATCH 2/4] Test unit ready is a nop and not defined --- src/BlueSCSI.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/BlueSCSI.cpp b/src/BlueSCSI.cpp index 51df232..debcee2 100644 --- a/src/BlueSCSI.cpp +++ b/src/BlueSCSI.cpp @@ -117,7 +117,6 @@ SCSI_COMMAND_HANDLER(onModeSelect); SCSI_COMMAND_HANDLER(onVerify); SCSI_COMMAND_HANDLER(onReadBuffer); SCSI_COMMAND_HANDLER(onWriteBuffer); -SCSI_COMMAND_HANDLER(onTestUnitReady); SCSI_COMMAND_HANDLER(onReZeroUnit); SCSI_COMMAND_HANDLER(onSendDiagnostic); SCSI_COMMAND_HANDLER(onReadDefectData); From d4f86ddaede1c09b5d27a7022990b280eb5595c5 Mon Sep 17 00:00:00 2001 From: Eric Helgeson Date: Sun, 26 Jun 2022 20:51:28 -0500 Subject: [PATCH 3/4] LED on/off is around all commands, no need to have it here. --- src/BlueSCSI.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/BlueSCSI.cpp b/src/BlueSCSI.cpp index debcee2..e4bb6bd 100644 --- a/src/BlueSCSI.cpp +++ b/src/BlueSCSI.cpp @@ -1157,9 +1157,7 @@ byte onVerify(SCSI_DEVICE *dev, const byte *cdb) // Data-Out buffer is single logical block for repeated verification. len = dev->m_blocksize; } - LED_ON(); verifyDataPhaseSD(dev, adds, len); - LED_OFF(); } return SCSI_STATUS_GOOD; } From 40e45906863ea438e4dc16f411b0db3cf081a81e Mon Sep 17 00:00:00 2001 From: Eric Helgeson Date: Sat, 16 Jul 2022 14:49:21 -0500 Subject: [PATCH 4/4] Product back to BLUESCSI F1 --- src/BlueSCSI.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BlueSCSI.cpp b/src/BlueSCSI.cpp index e4bb6bd..0827f45 100644 --- a/src/BlueSCSI.cpp +++ b/src/BlueSCSI.cpp @@ -302,7 +302,7 @@ void setup() default_hdd.response_format = 1; default_hdd.additional_length = 31; memcpy(&default_hdd.vendor, "QUANTUM", 7); - memcpy(&default_hdd.product, "FIREBALL1", 9); + memcpy(&default_hdd.product, "BLUESCSI F1", 11); memcpy(&default_hdd.revision, "1.0", 3); // default SCSI CDROM