Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position issue since Leaflet 1.0-rc2 #8

Open
buchanan-fh opened this issue Jul 19, 2016 · 3 comments
Open

Position issue since Leaflet 1.0-rc2 #8

buchanan-fh opened this issue Jul 19, 2016 · 3 comments
Assignees

Comments

@buchanan-fh
Copy link

I experience some position issues since Leaflet 1.0-rc2 : the top left corner of the popup always gets positioned on the marker, instead of the end of the tip

I think this might be related to this code change : Leaflet/Leaflet#4662

@erictheise
Copy link
Owner

Thanks for reporting the issue, @buchanan-fh. I admit I haven't been tracking progress with the long-delayed Leaflet 1.0 but I'm glad to know that people continue to find rrose useful and are planning to continue to use it with this upcoming major release.

Thanks, too, for identifying the potential source of the problem. I'll try and get a fix in place before the end of this upcoming weekend.

@erictheise erictheise self-assigned this Jul 19, 2016
@erictheise
Copy link
Owner

With today's release of Leaflet 1.0.0 I've upgraded the demo page. I haven't seen any positioning issues with the released version or any of the candidates in the context of Rrose's modest intended use case.

@buchanan-fh
Copy link
Author

I've been trying some thing to spot the problem compared to your example : it seems that when I don't define the offset when creating the popup gets it mispositioned.
Defining offset: new L.Point(0,0) seems to solve the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants