This repository has been archived by the owner on May 13, 2022. It is now read-only.
Use sha3 has for snative addresses for future-proofing #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasdavis
force-pushed
the
snative-templates
branch
from
0a8fe6c to
ec741ce
Compare
benjaminbollen
previously requested changes
Feb 23, 2017
manager/eris-mint/evm/snative.go
Outdated
| // hash of its name | ||
| func (contract *SNativeContractDescription) Address() abi.Address { | ||
| var address abi.Address | ||
| copy(address[:], sha3.Sha3([]byte(contract.Name))[:abi.AddressLength]) |
There was a problem hiding this comment.
Ethereum takes the right most 20 bytes of the 256bit Keccak digest; not the first 20 bytes;
see eris-keys here https://github.com/eris-ltd/eris-keys/blob/master/crypto/key.go#L152-L153
or also here http://bitcoin.stackexchange.com/questions/42055/what-is-the-approach-to-calculate-an-ethereum-address-from-a-256-bit-private-key
There was a problem hiding this comment.
that's of a public key though, so it's kind of unrelated... We could copy, but I can't see how it will make any difference. The point is just to have a uniform hash over the 20 bytes.
silasdavis
force-pushed
the
snative-templates
branch
from
ec741ce to
4ecc033
Compare
|
Overall nice improvement |
silasdavis
force-pushed
the
snative-templates
branch
from
a7dab6d to
94f21e7
Compare
VoR0220
approved these changes
Feb 23, 2017
|
Yes, I reviewed it last thing before I left, but forgot to merge. lgtm |
Merged
silasdavis
pushed a commit
to silasdavis/burrow
that referenced
this pull request
Mar 9, 2019
…emplates Use sha3 has for snative addresses for future-proofing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.