Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
All platforms. But tests only
What does this PR do?
At the Cordova-Common 3.1.0, the logger[level] property becomes not writable. (level = results, verbose, normal, warn, info, error)
Then we can't use SpyOn for logger[level] in jasmine tests.
Actually
npm run tests
fails likeTo resolve this issue, this PR overrides
CordovaLogger.prototype.addLevel
method in test code (i.e.cli.spec.js
) to make logger[level] property writable.What testing has been done on this change?
Checklist