Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate all logger events to Lager events #521

Open
hauleth opened this issue Nov 5, 2019 · 3 comments
Open

Translate all logger events to Lager events #521

hauleth opened this issue Nov 5, 2019 · 3 comments

Comments

@hauleth
Copy link

hauleth commented Nov 5, 2019

This is similar approach that Elixir's logger take some time ago, where Lager messages still will be handled by the Lager only, but it will also get messages from the logger module. This should easy the migration like mentioned in #519 where all messages are passed through logger from day 1. This would also resolve #492 as Lager would replace default handler for all messages, not just error_logger.

Later this could be improved in similar way to elixir-lang/elixir#9333

@jadeallenx
Copy link
Member

I think @Vagabond is planning along these lines for the future 4.x version of lager. Thanks for the issue though.

@hauleth
Copy link
Author

hauleth commented Nov 8, 2019

Yes, I have seen their work. My point is to reduce scope for a moment, and do not rewrite all log commands as well, but for now just provide logging facilities for logger (and soon Elixir's Logger) users.

@g-andrade
Copy link

My point is to reduce scope for a moment, and do not rewrite all log commands as well, [...]

In case more elegant alternatives don't come up within a short time frame, fake-lager might be useful to you, but it's still rather experimental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants