Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

fix: stricter directory import #17

Merged
merged 7 commits into from
May 25, 2022
Merged

fix: stricter directory import #17

merged 7 commits into from
May 25, 2022

Conversation

privatenumber
Copy link
Member

Problem

  • Resolving directories initially tried to resolve /index. This would be problematic if the file actually existed because it is not CommonJS behavior.
  • Error thrown on failed directory import was inaccurate

Closes #13

Changes

  • On directory import, directly import index file with extensions
  • Edit error thrown to be contain accurate request path

@privatenumber privatenumber merged commit a233682 into develop May 25, 2022
@privatenumber privatenumber deleted the directory-import-error branch May 25, 2022 14:57
@privatenumber
Copy link
Member Author

🎉 This PR is included in version 2.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve failed when the same name file and directory
1 participant
@privatenumber