-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove invalid es-builtins #258
Conversation
It may introduce new linting errors, which, according to eslint's versioning policy, I categorize as feat. https://github.com/eslint/eslint?tab=readme-ov-file#semantic-versioning-policy |
it's to fix the issue: #260 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this resolves #260 well
tips: it's recommended to use rebase, to help release-please generate better changelogs. :) |
As we're using squash merge, it actually makes no difference, as only the PR title is kept 👀 If we're using merge / rebase merge then 100% we'd need to worry :) |
"node builtins" is repeated 2 times, and I'm not sure if it has anything to do with the use of merge: |
😱 that makes no sense. I guess I will steer clear for now! |
These globals don't belong to ecma262, I moved them to node builtins. :)
fixes #260