Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invalid es-builtins #258

Merged
merged 2 commits into from
Apr 30, 2024
Merged

fix: remove invalid es-builtins #258

merged 2 commits into from
Apr 30, 2024

Conversation

aladdin-add
Copy link

@aladdin-add aladdin-add commented Apr 29, 2024

These globals don't belong to ecma262, I moved them to node builtins. :)

fixes #260

@aladdin-add aladdin-add changed the title feat: node builtins feat: update node builtins Apr 29, 2024
@aladdin-add
Copy link
Author

It may introduce new linting errors, which, according to eslint's versioning policy, I categorize as feat.

https://github.com/eslint/eslint?tab=readme-ov-file#semantic-versioning-policy

scagood

This comment was marked as outdated.

@aladdin-add
Copy link
Author

it's to fix the issue: #260

@scagood scagood changed the title feat: update node builtins fix: remove invalid es-builtins Apr 30, 2024
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this resolves #260 well

@aladdin-add aladdin-add marked this pull request as ready for review April 30, 2024 09:47
@aladdin-add aladdin-add merged commit ecdf019 into master Apr 30, 2024
19 checks passed
@aladdin-add aladdin-add deleted the feat/es-data branch April 30, 2024 09:47
@aladdin-add
Copy link
Author

tips: it's recommended to use rebase, to help release-please generate better changelogs. :)

@scagood
Copy link

scagood commented Apr 30, 2024

As we're using squash merge, it actually makes no difference, as only the PR title is kept 👀

If we're using merge / rebase merge then 100% we'd need to worry :)

@aladdin-add
Copy link
Author

"node builtins" is repeated 2 times, and I'm not sure if it has anything to do with the use of merge:
https://github.com/eslint-community/eslint-plugin-n/blob/a70789a90c118f1ab69b8e1f5d4f1ac7f5dc3869/CHANGELOG.md#-features

@scagood
Copy link

scagood commented Apr 30, 2024

😱 that makes no sense. I guess I will steer clear for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: no-unsupported-features/es-builtins false positives
2 participants