Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hashbang): Add support to map extensions to executables #278

Merged
merged 5 commits into from
May 14, 2024
Merged

feat(hashbang): Add support to map extensions to executables #278

merged 5 commits into from
May 14, 2024

Conversation

scagood
Copy link

@scagood scagood commented May 13, 2024 •
edited
Loading

fixes #220

@scagood scagood changed the title test: Rename shebang tests to be more verbose feat(hashbang): Add support to map extensions to executables May 13, 2024
@scagood scagood marked this pull request as ready for review May 13, 2024 19:39
aladdin-add
aladdin-add requested changes May 14, 2024
View reviewed changes
Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the docs also need to be updated :)

lib/rules/hashbang.js Show resolved Hide resolved
aladdin-add
aladdin-add approved these changes May 14, 2024
View reviewed changes
Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 3fd7639 into eslint-community:master May 14, 2024
23 checks passed
@github-actions github-actions bot mentioned this pull request May 14, 2024
Merged
@scagood scagood deleted the shebang branch May 14, 2024 08:59
@lholmquist lholmquist mentioned this pull request Jun 4, 2024
Closed
@sathish-pv sathish-pv mentioned this pull request Jun 6, 2024
Closed
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Merged
@junsulee junsulee mentioned this pull request Jun 25, 2024
Open
This was referenced Jun 27, 2024
Closed
Closed
@lholmquist lholmquist mentioned this pull request Jul 5, 2024
Closed
@WontonSam WontonSam mentioned this pull request Jul 16, 2024
Open
This was referenced Aug 2, 2024
Closed
Closed
This was referenced Aug 13, 2024
Closed
Closed
Open
@snyk-io snyk-io bot mentioned this pull request Aug 18, 2024
Open
This was referenced Aug 19, 2024
Closed
Closed
@WontonSam WontonSam mentioned this pull request Oct 11, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Oct 31, 2024
Open
This was referenced Nov 4, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: shebang code
2 participants
@scagood @aladdin-add