Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flag ignorePrivate to no-unpublished-x rules #298

Conversation

IchordeDionysos
Copy link

@IchordeDionysos IchordeDionysos commented Jun 13, 2024

This rule makes it possible to disable/enable the rule in private packages selectively.

Fixes #297
Make #296 obsolete

This rule make it possible to selectively disable/enable the rule in private packages
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small nits, but it looks good as a flag! 💪

Thanks

lib/rules/no-unpublished-import.js Outdated Show resolved Hide resolved
lib/rules/no-unpublished-require.js Outdated Show resolved Hide resolved
Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 0609431 into eslint-community:master Jun 14, 2024
23 checks passed
@IchordeDionysos IchordeDionysos deleted the feat/no-unpublished-x-ignore-private branch June 14, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Make disabling the no-unpublished-x rules in private packages opt-in
3 participants