Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: standardize npm script names #582

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Jul 29, 2023

Prerequisites checklist

What is the purpose of this pull request?

Refers eslint/eslint#14827

What changes did you make? (Give an overview)

This updates the names of the scripts in package.json to be consistent with the new standard.

Is there anything you'd like reviewers to focus on?

We may need to update the release related scripts on Jenkins before merging this PR.

Comment on lines -44 to -45
- name: Build commonjs
run: npm run build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build happens via the pretest script.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update README (npm test will no longer include linting):

https://github.com/eslint/espree/blob/086555ed960bd9cdbe9818cf962eaa1f5f32b737/README.md?plain=1#L186

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for @nzakas to verify.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit b0767ef into main Aug 7, 2023
@nzakas nzakas deleted the chore/standardize-npm-scripts branch August 7, 2023 15:08
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
@mdjermanovic
Copy link
Member

We may need to update the release related scripts on Jenkins before merging this PR.

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants