-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support ES2025 and RegExp duplicate named capturing groups #608
Conversation
@@ -42,7 +43,7 @@ function findTests(directory) { | |||
* @returns {void} | |||
*/ | |||
function outputResult(result, testResultFilename) { | |||
`export default ${tester.getAstCode(result)};`.to(testResultFilename); | |||
fs.writeFileSync(testResultFilename, `export default ${tester.getAstCode(result)};`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to an update to shelljs
, the previous code was no longer usable.
README.md
Outdated
|
||
Because ECMAScript 2024 is still under development, we are implementing features as they are finalized. Currently, Espree supports: | ||
Because ECMAScript 2024 and ECMAScript 2025 are still under development, we are implementing features as they are finalized. Currently, Espree supports: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ES2024 will be under development until the end of June, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that ECMAScript 2024 features are already finalized and that publishing the final spec in June is just a formality. So I think it's already safe to say that "Espree supports all ECMAScript 2024 features and partially supports ECMAScript 2025 features." but would like @nzakas's opinion too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I think it can only happen that some features get dropped from the final version, while no new features can be added at this point, so seems safe to say that we fully support ECMAScript 2024.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TC39 is meeting this week, so everything for 2024 should be finalized today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your comments! I've updated the README.
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Leaving open for @nzakas to verify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR enables ES2025 and changes ES2025 to the latest supported version.
It also adds support for RegExp duplicate named capturing groups.
Related to eslint/eslint#18330