Missing visitor-keys

[armano2]

I did some checking what we can and what we are not able to visit and i found some missing stuff:

missing typeParameters

• NewExpression - new foo<Foo>() Fix: visiting typeParameters in expressions #565
• CallExpression - foo<Foo>() Fix: visiting typeParameters in expressions #565
• TSAbstractClassDeclaration: Fix: visiting superTypeParameters in classes #561 - abstract class Foo<Bar> {}

missing superTypeParameters

class foo extends bar<Foo>

• ClassDeclaration: Fix: visiting superTypeParameters in classes #561
• ClassExpression: Fix: visiting superTypeParameters in classes #561
• TSAbstractClassDeclaration: Fix: visiting superTypeParameters in classes #561

missing implements

class foo implements bar, class foo implements bar, baz

• ClassDeclaration: Fix: visiting implements in classes #562
• ClassExpression: Fix: visiting implements in classes #562
• TSAbstractClassDeclaration: Fix: visiting implements in classes #562

missing import equals

import foo = require('foo')

• TSImportEqualsDeclaration Fix: scope for TSImportEqualsDeclaration #571
  • name
  • moduleReference
• TSExternalModuleReference Fix: scope for TSImportEqualsDeclaration #571
  • expression

invalid order:

• TSAbstractClassProperty : Fix: visitor-keys for TSAbstractClassProperty #560
  • key
  • typeAnnotation
  • value

missing decorators:

• TSAbstractClassProperty: Fix: visitor-keys for TSAbstractClassProperty #560
• TSAbstractClassDeclaration Fix: visiting superTypeParameters in classes #561

[armano2]

small update

[armano2]

@mysticatea i have question about implements do you think that it should be variable?

implements references to type -> interface which is type

[mysticatea]

No.

TypeScript has two namespaces: variables and types.

// Those are not redeclaration 
// because `interface` defines only in types and `const` defines only in variables.
interface A {}
const A = 0

// On the other hand, `class` defines in both types and variables.
class B {}

Then, the scopeManager doesn't have things of types namespace.
I think that we should provide a way to access types namespace, but we don't have it now.

[armano2]

ok, i was thinking correctly,

i just wanted to confirm that :)