Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API consistency for GPIO types #2006

Closed
MabezDev opened this issue Aug 27, 2024 · 3 comments · Fixed by #2133
Closed

API consistency for GPIO types #2006

MabezDev opened this issue Aug 27, 2024 · 3 comments · Fixed by #2133
Assignees
@bugadani
Milestone
0.21.0

Comments

@MabezDev
Copy link
Member

We should ensure that all our GPIO types have a consistent API across them all.

This may include making the Output/Input traits public again.

Related to #1995
@MabezDev MabezDev added this to the 0.21.0 milestone Aug 27, 2024
@bugadani bugadani self-assigned this Sep 3, 2024
@bugadani
Copy link
Contributor

bugadani commented Sep 3, 2024

This may include making the Output/Input traits public again.

Which traits are you referring to? InputPin and OutputPin are still public.

@bugadani bugadani mentioned this issue Sep 3, 2024
Merged
@Dominaezzz
Copy link
Collaborator

The APIs on them aren't public in a meaningful way. They have the crate::Internal param to prevent users from using them directly.

@bugadani
Copy link
Contributor

bugadani commented Sep 3, 2024

Right. Well, things will change.

@bugadani bugadani mentioned this issue Sep 4, 2024
Merged
@bugadani bugadani mentioned this issue Sep 11, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bugadani bugadani

Labels
None yet
Projects
esp-rs
Archived in project
Milestone
0.21.0
Development

Successfully merging a pull request may close this issue.

SPI pins are no longer optional bugadani/esp-hal
3 participants
@bugadani @MabezDev @Dominaezzz